This repository has been archived by the owner on May 25, 2021. It is now read-only.
Charts cleanup #585
Merged
Charts cleanup #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xorgy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @sumitarora, @clbond and @vanessayuenn to be potential reviewers |
|
|
|
🚀 |
xorgy
force-pushed
the
chart-cleanup
branch
2 times, most recently
from
617e2fe
to
d4be100
Compare
- Style the Injector Tree with CSS. - Simplify GraphUtils. - Make vertical connection lines shorter. - Use ViewChild for the graphContainer element instead of a global id. - Remove dead legend rendering code. - Draw nodes, labels, and connections in stacking order to prevent lines from overlapping nodes. - Calculate dependency connection lines correctly using polar coordinates. - Only draw the first connecting line when the target is not the selected component. - Remove unnecessary module imports.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces CSS styling for the Router Tree and Injector Tree, which eliminates the need to pass
themeinto InjectorTree, InfoPanel, RouterTree, and in turn AppTrees. This also eliminates a side effect whereby changing the theme would cause the Info Panel and Router Tree to re-render (throwing away local UI state).