Fix "application error" communication, introduce new class of error for AoT applications, introduce performance optimization for applications that are not being debugged #741
Conversation
clbond
commented
Oct 18, 2016
clbond
commented
- Resolve problem with ApplicationError communication between backend and frontend
- Add new class of error for applications built with AoT enabled and cannot be debugged
- Introduce new performance optimization where we do not subscribe to Angular changes unless we know the developer has actually opened the wAugury tab
|
@clbond, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xorgy, @sumitarora and @stevenkampen to be potential reviewers. |
|
everything looks good @clbond, just a couple of questions in my comments. Other than that I think the best would be to describe the story for this under a separate issue so as to know what to expect this code to do. What do you think? |
| const bind = (root: DebugElement) => { | ||
| if (root.injector == null) { | ||
| // In AoT-enabled debug builds, the data we get back from {@link ng.probe} |
There was a problem hiding this comment.
This is not completely true. A user has to do both:
- use AOT in debug mode and
- NOT call
enableProdMode()
Then this data is filled, even with AOT.
There was a problem hiding this comment.
This is not my experience. I created a new app with "ng new" and then ran with "ng serve --aot=true --debug=true".
In my Console it says: lang.js:255 Angular 2 is running in the development mode. Call enableProdMode() to enable the production mode.
Then if I try to get the DebugElement for the root component using ng.probe($('app-root')), I get this object back:
DebugElement {_debugInfo: null, nativeNode: app-root, parent: null, listeners: Array[0], properties: Object…}
_debugInfo: null
attributes: Object
childNodes: Array[2]
children: (...)
classes: Object
componentInstance: null
context: null
injector: null
listeners: Array[0]
nativeElement: app-root
nativeNode: app-root
parent: null
properties: Object
providerTokens: (...)
references: (...)
source: (...)
styles: Object
__proto__: DebugNode
On this object, both injector and componentInstance are null
|
This resolves #742 |
|
I removed the comment and made the error messages more generic. |
… and frontend * Add new class of error for applications built with AoT enabled and cannot be debugged * Introduce new performance optimization where we do not subscribe to Angular changes unless we know the developer has actually opened the Augury tab
…es for missing debug info or missing "window.ng" property
