Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elb create/delete, listener add/delete and health check commands #3

Merged
merged 5 commits into from
Oct 20, 2014

Conversation

bernd
Copy link
Contributor

@bernd bernd commented Oct 20, 2014

This adds sub commands for elb create/delete, elb listener add/delete and elb health check.

@ranjib
Copy link
Owner

ranjib commented Oct 20, 2014

awesome . $stdout.sync = true is needed? If we must need it, can you make it configurable. knife plugins can be re-used in other scripts, and in that case the consumer script might decide to control this behavior

thanks for the patch :-)

@bernd
Copy link
Contributor Author

bernd commented Oct 20, 2014

I copied the stdout.sync settings from the elb_list.rb. So no, it is not needed I guess. 😉 Removed!

@ranjib
Copy link
Owner

ranjib commented Oct 20, 2014

thank. i'll nuke it from the list code :-)

ranjib added a commit that referenced this pull request Oct 20, 2014
Add elb create/delete, listener add/delete and health check commands
@ranjib ranjib merged commit 1cff264 into ranjib:master Oct 20, 2014
@bernd
Copy link
Contributor Author

bernd commented Oct 20, 2014

Great, thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants