Fix erroneous cred reporting in SonicWALL exploit

A valid session ID will be returned in JSON if the login succeeded. {"userid"=>"1", "sessionid"=>"4WJ9cNg1TkBrwjzX"}
rapid7 · Oct 11, 2016 · 1ad80da · 1ad80da
1 parent 55348d7
commit 1ad80da
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/exploits/multi/http/sonicwall_scrutinizer_methoddetail_sqli.rb b/modules/exploits/multi/http/sonicwall_scrutinizer_methoddetail_sqli.rb
@@ -180,10 +180,10 @@ def do_login
       fail_with(Failure::NoAccess, "Username '#{datastore['USERNAME']}' is incorrect.")
     elsif res['loginfailed']
       fail_with(Failure::NoAccess, "Password '#{datastore['PASSWORD']}' is incorrect.")
+    elsif res['sessionid']
+      report_cred(datastore['USERNAME'], datastore['PASSWORD'])
     end
 
-    report_cred(datastore['USERNAME'], datastore['PASSWORD'])
-
     res
   end