Land #13886, post/multi/manage/sudo support password with shell metac…

…haracters
rapid7 · Jul 23, 2020 · 2379194 · 2379194
2 parents bbb683f + 6be25a0
commit 2379194
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/modules/post/multi/manage/sudo.rb b/modules/post/multi/manage/sudo.rb
@@ -98,8 +98,7 @@ def askpass_sudo(password)
         # Need to timeout in case there's a blocking prompt after all
         ::Timeout.timeout(120) do
           vprint_status "Writing the SUDO_ASKPASS script: #{askpass_sh}"
-          cmd_exec("echo \\#\\!/bin/sh > #{askpass_sh}") # Cursed csh
-          cmd_exec("echo echo #{password} >> #{askpass_sh}")
+          write_file(askpass_sh, "#!/bin/sh\necho '#{password}'\n")
           vprint_status "Setting executable bit."
           cmd_exec("chmod +x #{askpass_sh}")
           vprint_status "Setting environment variable."