Land #10611, mRemote creds gather module fixes

Also update #10612 to align with these changes.
rapid7 · Sep 10, 2018 · 29b16e1 · 29b16e1
1 parent 67e1742
commit 29b16e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/modules/post/multi/gather/jenkins_gather.rb b/modules/post/multi/gather/jenkins_gather.rb
@@ -53,7 +53,7 @@ def parse_credentialsxml(file)
     if exists?(file)
       f = read_file(file)
       if datastore['STORE_LOOT']
-        loot_path = store_loot('jenkins.credentials', 'text/xml', session, f)
+        loot_path = store_loot('jenkins.creds', 'text/xml', session, f, file)
         vprint_status("File credentials.xml saved to #{loot_path}")
       end
     else

diff --git a/modules/post/windows/gather/credentials/mremote.rb b/modules/post/windows/gather/credentials/mremote.rb
@@ -39,7 +39,7 @@ def run
     grab_user_profiles().each do |user|
       next if user['LocalAppData'] == nil
       tmpath  = user['LocalAppData'] + '\\Felix_Deimel\\mRemote\\confCons.xml'
-      ng_path = user['LocalAppData'] + '\\..\\Roaming\\mRemoteNG\\confCons.xml'
+      ng_path = user['AppData'] + '\\mRemoteNG\\confCons.xml'
       get_xml(tmpath)
       get_xml(ng_path)
     end
@@ -50,6 +50,8 @@ def get_xml(path)
     begin
       if file_exist?(path)
         condata = read_file(path)
+        loot_path = store_loot('mremote.creds', 'text/xml', session, condata, path)
+        vprint_good("confCons.xml saved to #{loot_path}")
         parse_xml(condata)
         print_status("Finished processing #{path}")
       end