Land #4242, @Meatballs1 fix for sap_service_discovery report_note

* I cannot reproduce @Meatballs1 issue * But I noticed report_note should :update with :unique_data * Fixed the :update
rapid7 · Nov 21, 2014 · 3ac1f7d · 3ac1f7d
2 parents 90ae9a3 + e30ee9f
commit 3ac1f7d
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/modules/auxiliary/scanner/sap/sap_service_discovery.rb b/modules/auxiliary/scanner/sap/sap_service_discovery.rb
@@ -227,15 +227,13 @@ def run_host(ip)
               end
             print_good("#{ip}:#{port}\t - #{service} OPEN")
 
-            begin
-              report_note(
-                :host => "#{ip}",
-                :proto => 'TCP',
-                :port => "#{port}",
-                :type => 'SAP',
-                :data => "#{service}"
-              )
-            end
+            report_note(
+              :host => "#{ip}",
+              :port => "#{port}",
+              :type => 'SAP',
+              :data => "#{service}",
+              :update => :unique_data
+            )
             r << [ip,port,"open", service]
             rescue ::Rex::ConnectionRefused
               vprint_status("#{ip}:#{port}\t - TCP closed")