fix #9112, improve error message on failure

rapid7 · Feb 20, 2018 · 5083150 · 5083150
1 parent a01f0f3
commit 5083150
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/ui.rb b/lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/ui.rb
@@ -152,7 +152,7 @@ def cmd_screenshot( *args )
 
     data = client.ui.screenshot( quality )
 
-    if( data )
+    if data
       ::File.open( path, 'wb' ) do |fd|
         fd.write( data )
       end
@@ -162,6 +162,11 @@ def cmd_screenshot( *args )
       print_line( "Screenshot saved to: #{path}" )
 
       Rex::Compat.open_file( path ) if view
+    else
+      print_error("No screenshot data was returned.")
+      if client.platform == 'android'
+        print_error("On Android this command can only capture the application's own framebuffer.")
+      end
     end
 
     return true