reduce nesting in the check routine

modules/exploits/multi/misc/apache_activemq_rce_cve_2023_46604.rb

@@ -92,27 +92,24 @@ def check
 
     return CheckCode::Unknown unless magic == 'ActiveMQ'
 
-    if res =~ /ProviderVersion...(\d+\.\d+\.\d+)/
+    return CheckCode::Detected unless res =~ /ProviderVersion...(\d+\.\d+\.\d+)/
 
-      version = Rex::Version.new(::Regexp.last_match(1))
+    version = Rex::Version.new(::Regexp.last_match(1))
 
-      ranges = [
-        ['5.18.0', '5.18.2'],
-        ['5.17.0', '5.17.5'],
-        ['5.16.0', '5.16.6'],
-        ['0.0.0', '5.15.15']
-      ]
+    ranges = [
+      ['5.18.0', '5.18.2'],
+      ['5.17.0', '5.17.5'],
+      ['5.16.0', '5.16.6'],
+      ['0.0.0', '5.15.15']
+    ]
 
-      ranges.each do |min, max|
-        if version.between?(Rex::Version.new(min), Rex::Version.new(max))
-          return Exploit::CheckCode::Appears("Apache ActiveMQ #{version}")
-        end
+    ranges.each do |min, max|
+      if version.between?(Rex::Version.new(min), Rex::Version.new(max))
+        return Exploit::CheckCode::Appears("Apache ActiveMQ #{version}")
       end
-
-      return Exploit::CheckCode::Safe("Apache ActiveMQ #{version}")
     end
 
-    CheckCode::Detected
+    Exploit::CheckCode::Safe("Apache ActiveMQ #{version}")
   end
 
   def exploit