External modules have some stringified Bools

[wvu]

**DisablePayloadHandler: True   (RHOST and RPORT settings will be ignored!)**

msf5 exploit(windows/smb/ms17_010_eternalblue_win8) > set DisablePayloadHandler
DisablePayloadHandler => false
msf5 exploit(windows/smb/ms17_010_eternalblue_win8) >

[1] pry(#<Msf::Modules::Mod6578706c6f69742f77696e646f77732f736d622f6d7331375f3031305f657465726e616c626c75655f77696e38::MetasploitModule>)> datastore
=> {"WfsDelay"=>"5",
 "WORKSPACE"=>nil,
 "VERBOSE"=>"false",
 "EnableContextEncoding"=>"false",
 "ContextInformationFile"=>nil,
 "DisablePayloadHandler"=>"false",
 "SMBUser"=>"",
 "SMBPass"=>"",
 "GroomAllocations"=>"13",
 "RHOST"=>"192.168.56.101",
 "RPORT"=>"445",
 "payload"=>"windows/x64/meterpreter/reverse_tcp",
 "lhost"=>"192.168.56.1",
 "LPORT"=>4444,
 "ReverseListenerBindPort"=>nil,
 "ReverseAllowProxy"=>false,
 "ReverseListenerComm"=>nil,
 "ReverseListenerBindAddress"=>nil,
 "ReverseListenerThreaded"=>false,
 "StagerRetryCount"=>10,
 "StagerRetryWait"=>5,
 "PayloadUUIDSeed"=>nil,
 "PayloadUUIDRaw"=>nil,
 "PayloadUUIDName"=>nil,
 "PayloadUUIDTracking"=>false,
 "EnableStageEncoding"=>false,
 "StageEncoder"=>nil,
 "StageEncoderSaveRegisters"=>"",
 "StageEncodingFallback"=>true,
 "PrependMigrate"=>false,
 "PrependMigrateProc"=>nil,
 "EXITFUNC"=>"process",
 "AutoLoadStdapi"=>true,
 "AutoVerifySession"=>true,
 "AutoVerifySessionTimeout"=>30,
 "InitialAutoRunScript"=>"",
 "AutoRunScript"=>"",
 "AutoSystemInfo"=>true,
 "EnableUnicodeEncoding"=>false,
 "HandlerSSLCert"=>nil,
 "SessionRetryTotal"=>3600,
 "SessionRetryWait"=>10,
 "SessionExpirationTimeout"=>604800,
 "SessionCommunicationTimeout"=>300,
 "PayloadProcessCommandLine"=>""}
[2] pry(#<Msf::Modules::Mod6578706c6f69742f77696e646f77732f736d622f6d7331375f3031305f657465726e616c626c75655f77696e38::MetasploitModule>)>

lib/msf/ui/console/command_dispatcher/common.rb:        print("   **DisablePayloadHandler: True   (RHOST and RPORT settings will be ignored!)**\n\n") if mod.datastore['DisablePayloadHandler']

[acammack-r7]

To see what the external module would see, you can use datastore.to_nested_values to be sure (not an issue here, just a tip). Are you setting a default somewhere?

[wvu]

Nope, I'm not doing anything for DisablePayloadHandler. I'm setting RHOST, RPORT, GroomAllocations, SMBUser, and SMBPass - noticing that they're also stringified.

[wvu]

Figured out where it's coming from. When used with save, DisablePayloadHandler is being set in ~/.msf4/config automatically.

[Knowledge-Wisdom-Understanding]

Has anybody solved this issue? How can I fix it?

[acammack-r7]

@Knowledge-Wisdom-Understanding are you running into an issue like this? If so, what are you seeing? The particular problem with DisablePayloadHandler here (especially with save, and maybe other options then, too) is that when you set an unregistered option it is assumed to be a string, and I believe that either it may not always be registered before deeper code uses it or the type isn't getting picked up/normalized correctly before the module runs.