Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce DisablePayloadHandler into a Boolean string #10989

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Coerce DisablePayloadHandler into a Boolean string #10989

merged 1 commit into from
Nov 19, 2018

Conversation

wvu
Copy link
Contributor

@wvu wvu commented Nov 19, 2018 •
edited
Loading

Due to discrepancies in how command dispatchers receive datastore options, especially after a save of the console, Boolean values are stored as strings.

This is a quick fix for DisablePayloadHandler specifically, since it was driving me insane.

msf5 exploit(unix/local/[redacted]) > pry
[*] Starting Pry shell...
[*] You are in exploit/unix/local/[redacted]

[1] pry(#<Msf::Modules::Exploit__Unix__Local__[redacted]::MetasploitModule>)> datastore['DisablePayloadHandler']
=> "false"
[2] pry(#<Msf::Modules::Exploit__Unix__Local__[redacted]::MetasploitModule>)>

Closes #10179 and closes #10240. Does not fix the systemic issue.

@wvu
Coerce DisablePayloadHandler into a Boolean string
6d317ba 
Due to discrepancies in how command dispatchers receive datastore
options, especially after a "save" of the console, Boolean values are
stored as strings.

This is a quick fix for DisablePayloadHandler specifically, since it was
driving me insane.
@busterb busterb self-assigned this Nov 19, 2018
@bcook-r7 bcook-r7 merged commit 6d317ba into rapid7:master Nov 19, 2018
bcook-r7 pushed a commit that referenced this pull request Nov 19, 2018
@busterb
Land #10989, Coerce DisablePayloadHandler into a Boolean string
8c20090
@busterb
Copy link
Member

busterb commented Nov 19, 2018 •
edited by gdavidson-r7
Loading

Release Notes

This fixes an issue where saving and restoring datastore state leads to an incorrect message about the payload handler being disabled.

@wvu wvu deleted the bug/boolean branch November 19, 2018 19:27
msjenkins-r7 pushed a commit that referenced this pull request Nov 19, 2018
@busterb @msjenkins-r7
Land #10989, Coerce DisablePayloadHandler into a Boolean string
a0dd790
@gdavidson-r7 gdavidson-r7 added the rn-fix release notes fix label Nov 29, 2018
@wvu wvu mentioned this pull request Dec 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@busterb busterb

Labels
bug library msfconsole rn-fix release notes fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DisablePayloadHandler has mind of its own when saving config External modules have some stringified Bools
4 participants
@wvu @busterb @bcook-r7 @gdavidson-r7