New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce DisablePayloadHandler into a Boolean string #10989

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
4 participants
@wvu-r7
Contributor

wvu-r7 commented Nov 19, 2018

Due to discrepancies in how command dispatchers receive datastore options, especially after a save of the console, Boolean values are stored as strings.

This is a quick fix for DisablePayloadHandler specifically, since it was driving me insane.

msf5 exploit(unix/local/[redacted]) > pry
[*] Starting Pry shell...
[*] You are in exploit/unix/local/[redacted]

[1] pry(#<Msf::Modules::Exploit__Unix__Local__[redacted]::MetasploitModule>)> datastore['DisablePayloadHandler']
=> "false"
[2] pry(#<Msf::Modules::Exploit__Unix__Local__[redacted]::MetasploitModule>)>

Closes #10179 and closes #10240. Does not fix the systemic issue.

Coerce DisablePayloadHandler into a Boolean string
Due to discrepancies in how command dispatchers receive datastore
options, especially after a "save" of the console, Boolean values are
stored as strings.

This is a quick fix for DisablePayloadHandler specifically, since it was
driving me insane.

@busterb busterb self-assigned this Nov 19, 2018

@bcook-r7 bcook-r7 merged commit 6d317ba into rapid7:master Nov 19, 2018

1 of 3 checks passed

Metasploit Automation - Sanity Test Execution Failed to pass tests.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details

bcook-r7 pushed a commit that referenced this pull request Nov 19, 2018

@busterb

This comment has been minimized.

Contributor

busterb commented Nov 19, 2018

Release Notes

This fixes an issue where saving and restoring datastore state leads to an incorrect message about the payload handler being disabled.

@wvu-r7 wvu-r7 deleted the wvu-r7:bug/boolean branch Nov 19, 2018

msjenkins-r7 added a commit that referenced this pull request Nov 19, 2018

@gdavidson-r7 gdavidson-r7 added the rn-fix label Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment