Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external scripts checker #14419

Merged
merged 5 commits into from Nov 24, 2020

Conversation

h00die
Copy link
Contributor

@h00die h00die commented Nov 21, 2020

This PR does a few things:

  1. Updates check_external_scripts.rb to update wordpress plugins and templates since they change often.
  2. Updates the wordpress plugins and templates files.
  3. Updates check_external_scripts.rb to check for bloodhound in their new path
  4. Lastly takes the script from update joomla wordlists #11199 (comment) and puts it in the framework so it doesn't get lost. I ran it, no changes. We most likely need to update the plugin source, as the owasp code hasn't been updated in 15 months or so.

Bloodhound, and john have updated files

Since bloodhound uses an EXE, an r7 person will have to update it and verify it works.
For the john updates, don't worry about it for now. I'll work with @jmartin-r7 on something new to test this kind of change.

Verification

  • Verify the contents of the wordpress files look to be the correct format
  • Verify the changes to check_external_scripts look fine
  • Verify update_joomla_components.py looks good

Copy link
Contributor

@smcintyre-r7 smcintyre-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran both tools and they both worked as expected. The python code looks fine and the ruby is mostly definition updates so that's cool too.

Thanks for updating all this! I'll land it in a moment.

@smcintyre-r7 smcintyre-r7 merged commit 1151d3d into rapid7:master Nov 24, 2020
@smcintyre-r7
Copy link
Contributor

smcintyre-r7 commented Nov 24, 2020

Release Notes

Updated external development scripts used to acquire the latest static resources for certain external framework components. Additionally updated two Wordpress wordlists.

@h00die h00die deleted the update_external-scripts branch November 25, 2020 12:52
@pbarry-r7 pbarry-r7 added enhancement rn-enhancement release notes enhancement labels Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants