Expand wordpress_scanner to look for themes & plugins #14423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcintyre-r7
requested changes
Dec 2, 2020
| @@ -188,29 +188,29 @@ def extract_and_check_version(body, type, item_type, fixed_version = nil, vuln_i | |||
| if fixed_version.nil? | |||
| if vuln_introduced_version.nil? | |||
| # All versions are vulnerable | |||
| return Msf::Exploit::CheckCode::Appears | |||
| return Msf::Exploit::CheckCode::Appears(details:version) | |||
There was a problem hiding this comment.
Love it, you're using the new CheckCode details I added. Would it be better though to update this to details: {version: version} to allow additional keys to be added to the check code details in the future? It may make sense to include a list of plugins someday. Using a hash with a version key would mean that we wouldn't need to refactor a bunch of things and cross our fingers that we got them all if in the future we want to add more data.
documentation/modules/auxiliary/scanner/http/wordpress_scanner.md
Outdated
Show resolved
Hide resolved
|
should be good! |
|
travis check this please as the results look like a github failure |
|
It looks like all the feedback has been addressed except for the details being the raw version string instead of a hash containing the version string per this comment. |
|
sometimes you forget to |
|
So I was confused why the unit tests passed after the details was updated to a hash and I found out why: Looks like the CheckCodes do not compare the details when it comes to equality checks. This makes sense so Safe always equals Safe even if the details contain different versions or whatever. What that means for this PR however is the specs should be updated to drop the details since they're not being compared. I'll go ahead and handle that after testing this. |
|
Well it took a couple of hours to run but this finished successfully and added all the proper notes. I'll go ahead and fix the unit tests, wait for travis to pass and then land this. Travis has been extra slow lately so it maybe 24 hours after I push the test changes but I'll handle it from here. Thanks a lot @h00die, this is an awesome improvement for the scanner. Testing Output |
smcintyre-r7
approved these changes
Dec 8, 2020
|
awesome! glad to hear its working |
Release NotesUpdated the Wordpress Scanner module to also identify common themes and plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember that time in #14419 where we added updates to
wp-plugins.txtandwp-themes.txt? Yea, well:We have these files, which are huge, and aren't used. Instead of removing them, lets use them!
This PR updates
wordpress_scannerto also enumerate themes and plugins. It also modifies the theme/plugin version wordpress lib to return the version in the details thanks to #14294 . Also a rubocop, and msftidy_docs.Verification
msfconsoleuse auxiliary/scanner/http/wordpress_versionset rhosts [ip]runIs it worth adding a note? The version part does that, I was 50/50 if it was worth the effort, not sure many people actually use notes. I'll take input.