Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module msftidy fixes #10207

Merged
merged 2 commits into from Jun 26, 2018
Merged

Module msftidy fixes #10207

merged 2 commits into from Jun 26, 2018

Conversation

jrobles-r7
Copy link
Contributor

@jrobles-r7 jrobles-r7 commented Jun 26, 2018

Verification steps

  • Run msftidy on the modified modules in the PR
  • There shouldn't be any warnings or errors

@bcoles
Copy link
Contributor

bcoles commented Jun 26, 2018

LGTM

Copy link
Contributor

@wvu wvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

'method' => 'POST',
'vars_get' => {
'step' => '4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number doesn't have to be a string, since it's coerced into one, but this is good.

wvu added a commit to wvu/metasploit-framework that referenced this pull request Jun 26, 2018
@wvu wvu merged commit c4bf12c into rapid7:master Jun 26, 2018
msjenkins-r7 pushed a commit that referenced this pull request Jun 26, 2018
@jrobles-r7 jrobles-r7 deleted the module-msftidy-fixes branch June 29, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants