Add support for HTTP POST and Basic Auth to psnuffle #10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvu
reviewed
Jul 17, 2018
| } | ||
| end | ||
|
|
||
| def parse(pkt) | ||
| # We want to return immediantly if we do not have a packet which is handled by us | ||
| # We want to return immediatly if we do not have a packet which is handled by us |
There was a problem hiding this comment.
This is the only thing I'd change for sure. :-)
wvu
reviewed
Jul 17, 2018
| class SnifferURL < BaseProtocolParser | ||
| def register_sigs | ||
| self.sigs = { | ||
| :get => /^GET\s+([^\n]+)\s+HTTP\/\d\.\d/i, | ||
| :webhost => /^HOST\:\s+([^\n\r]+)/i, | ||
| :get => /^GET\s+([^\n]+)\s+HTTP\/\d\.\d/i, |
There was a problem hiding this comment.
Assuming you're keeping the style because no one really uses this anymore anyway.
wvu
reviewed
Jul 17, 2018
| end | ||
| if s[:basic_auth] | ||
| s[:user], s[:pass] = Rex::Text.decode_base64(s[:basic_auth]).split(':', 2) | ||
| report_auth_info s |
There was a problem hiding this comment.
Same down here re style. No one really uses this. I'd change it to store_valid_credential, but there are other calls to pSnuffle's report_auth_info.
There was a problem hiding this comment.
Left it the same for consistency. Figured I someone would update all the report_auth_info in one go. I left it out for now to prevent merge conflicts.
wvu
reviewed
Jul 17, 2018
| @@ -1,22 +1,24 @@ | |||
| # Psnuffle password sniffer add-on class for HTTP GET URL's | |||
| # Psnuffle password sniffer add-on class for HTTP URLs | |||
There was a problem hiding this comment.
This file isn't even in the right place. :/
msjenkins-r7
pushed a commit
that referenced
this pull request
Jul 17, 2018
Release NotesHTTP POST and basic authentication support has been added to pSnuffle. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for HTTP POST and Basic Authentication to psnuffle.
From the does-anyone-even-use-this department.
This code is pretty bad. It's probably not even correct. The psnuffle codebase did not age well, the code comments are a lie, and the documentation does not exist.
Also, I removed
sessions.delete(s[:session]). Seems like that was probably important to prevent using tonnes of memory.¯\_(ツ)_/¯Test
HTTP Basic Authentication
Marvel at this beautiful output.
HTTP POST