Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for php5 as target #10487

Merged
merged 3 commits into from Aug 27, 2018
Merged

Added support for php5 as target #10487

merged 3 commits into from Aug 27, 2018

Conversation

CJHackerz
Copy link
Contributor

@CJHackerz CJHackerz commented Aug 19, 2018

location of the session file in php5 is /var/lib/php5/sess_file

location of the session file in php5 is /var/lib/php5/sess_file
Copy link
Contributor

@h00die h00die left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I would go about this differently. I would leave Linux as the Linux target and not differentiate php versions. Then change data path to be an array and loop through that way it can check php5, php6, php7, php8 and php.
That makes it more future proof and automates the task of fidning the file so the user doesn't have to

@acammack-r7
Copy link
Contributor

I agree with @h00die, I think this is too minor of a variation to have a separate target.

@wvu
Copy link
Contributor

wvu commented Aug 23, 2018

Agree with @h00die and @acammack-r7.

@jrobles-r7
Copy link
Contributor

I opened a PR on @CJHackerz repo to use an array for the file paths.

Additional path for Linux target
@jrobles-r7 jrobles-r7 merged commit 332036b into rapid7:master Aug 27, 2018
jrobles-r7 added a commit that referenced this pull request Aug 27, 2018
@jrobles-r7
Copy link
Contributor

jrobles-r7 commented Aug 27, 2018

Release Notes

An additional session file path has been added in the exploits/multi/http/phpmyadmin_lfi_rce module for the Linux target. The additional path adds support for php5 session files.

msjenkins-r7 pushed a commit that referenced this pull request Aug 27, 2018
@tdoan-r7 tdoan-r7 added the rn-enhancement release notes enhancement label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants