Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix msftidy EDB link check #10527

Merged
merged 1 commit into from Aug 27, 2018
Merged

Fix msftidy EDB link check #10527

merged 1 commit into from Aug 27, 2018

Conversation

bcoles
Copy link
Contributor

@bcoles bcoles commented Aug 26, 2018 •
edited by wvu

Fix msftidy EDB link check.

Check for both http:// and https://

@busterb
Copy link
Member

busterb commented Aug 27, 2018

Good change, thanks.

@busterb busterb self-assigned this Aug 27, 2018
@busterb busterb merged commit 9725e90 into rapid7:master Aug 27, 2018
busterb added a commit that referenced this pull request Aug 27, 2018
@busterb
Land #10527, Fix msftdiy EDB link check, enable HTTPS
47ca6c6
@busterb
Copy link
Member

busterb commented Aug 27, 2018 •
edited by tdoan-r7

Release Notes

Exploit-DB reference links now use HTTPS in all modules.

msjenkins-r7 pushed a commit that referenced this pull request Aug 27, 2018
@busterb @msjenkins-r7
Land #10527, Fix msftdiy EDB link check, enable HTTPS
f22e6ec
@firefart
Copy link
Contributor

@bcoles @busterb shouldn't we check all link types for https too? Like the microsoft ones?

@firefart
Copy link
Contributor

addressed it here:
#10536

@wvu wvu changed the title Fix msftdiy EDB link check Fix msftidy EDB link check Aug 27, 2018
@bcoles bcoles deleted the msftidy_edb branch August 28, 2018 06:55
@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@busterb busterb

Labels
easy msftidy newbie-friendly rn-fix release notes fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoles @busterb @firefart @tdoan-r7