Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DisclosureDate format #11093

Closed
wants to merge 1 commit into from
Closed

Fix DisclosureDate format #11093

wants to merge 1 commit into from

Conversation

Auxilus
Copy link
Contributor

@Auxilus Auxilus commented Dec 9, 2018

No description provided.

@bcoles
Copy link
Contributor

bcoles commented Dec 9, 2018

Nooooo. That's worse.

@Auxilus
Copy link
Contributor Author

Auxilus commented Dec 9, 2018

face-palm what did I do wrong? 🙄

@bcoles
Copy link
Contributor

bcoles commented Dec 9, 2018

You converted the date format from awesome to terrible.

@Auxilus
Copy link
Contributor Author

Auxilus commented Dec 9, 2018

I saw https://github.com/rapid7/metasploit-framework/wiki/How-to-get-started-with-writing-an-exploit says that DisclosureDate format should be like Apr 04 2014

@bcoles
Copy link
Contributor

bcoles commented Dec 9, 2018

That's fake news. See: #10974

@Auxilus
Copy link
Contributor Author

Auxilus commented Dec 9, 2018

hehe 😬, I'll fix that 😅, I did the opposite thing 😬

so Mar 26 2014 should be 2014-03-26 right?
I just saw that most of the modules have DisclosureDate in format MM DD YYYY.....

@Auxilus
Copy link
Contributor Author

Auxilus commented Dec 9, 2018

Wiki needs to be updated??

@Auxilus Auxilus closed this Dec 9, 2018
@Auxilus Auxilus deleted the DisclosureDate branch December 9, 2018 17:22
@bcoles
Copy link
Contributor

bcoles commented Dec 10, 2018

so Mar 26 2014 should be 2014-03-26 right?

Correct.

Wiki needs to be updated??

Yeah a bunch of things in the wiki need to be updated.

@bcoles bcoles mentioned this pull request Oct 2, 2020
Merged
4 tasks
@adfoster-r7 adfoster-r7 mentioned this pull request Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Auxilus @bcoles