Improve misleading update() actions from db_manager #11222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find all instances where
Mdm::Xxx::update()
is called and replace them with anupdate!()
call on an instance of the object, instead of calling directly from theMdm
class.From the original bug report (MS-3082):
This happens locally, as well as through the API (MS-3675):
Verification
./msfdb start
https://localhost:8080/api/v1/api-docs
Test host
Test loot
Test note
Test service
Test session
Test user
Test workspace
Things not included in these testing instructions
lib/msf/core/db_manager/user.rb
create_new_user_token
)lib/msf/core/db_manager/vuln_detail.rb
update_vuln_details
)