Add check for writable and nosuid WritableDir #11239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds enhances the
exploit/linux/local/docker_daemon_privilege_escalation
module (added in #7027) to check whether the user-specifiedWritableDir
is writable and mounted withoutnosuid
.Before these changes:
WritableDir
was not writable, the module would (likely) fail horriblyWritableDir
was mountednosuid
, the module would fail to privesc - probably return a new low-privileged session or no new session.While I was at it, a check for
CheckCode::Vulnerable
within theexploit
method, and an associatedForceExploit
code pattern, were added.I haven't tested these changes on a vulnerable system. I have, however, at least verified that the changes appear to not horribly break the module on a non-vulnerable system.