New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uppercase KoreLogic in JTR modules #11263

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
4 participants
@h00die
Copy link
Contributor

h00die commented Jan 15, 2019

This PR standardizes the KoreLogic option in the JTR modules to be uppercase.

@h00die h00die changed the title uppercase uppercase KoreLogic in JTR modules Jan 15, 2019

@h00die h00die referenced this pull request Jan 15, 2019

Closed

WIP: jtr_* modernizations #11264

0 of 3 tasks complete
@jrobles-r7

This comment has been minimized.

Copy link
Contributor

jrobles-r7 commented Jan 15, 2019

modules/auxiliary/analyze/jtr_aix.rb would need to be updated too.

@h00die

This comment has been minimized.

Copy link
Contributor Author

h00die commented Jan 15, 2019

Yup, that's in #11264 . Aix hasn't worked, according to my research, in 5yrs so I don't think this will be a hold up

@jrobles-r7 jrobles-r7 self-assigned this Jan 15, 2019

@jrobles-r7

This comment has been minimized.

Copy link
Contributor

jrobles-r7 commented Jan 15, 2019

Oh ok. Thanks for pointing that out.

@h00die

This comment has been minimized.

Copy link
Contributor Author

h00die commented Jan 15, 2019

Sorry for the confusion. Originally I started by just working on docs for jtr_*, and while working through it I started noticing a bunch of library-ish stuff that was off, which then started to become one GIANT PR which worked on all jtr modules and the associated libraries, or trying to pick some of it out for smaller PRs. I didn't want to have 2 PRs modifying the same file just in case there was a collision or other unintended issue. But after figuring out aix didn't work at all and hadn't in so long, I figured this would be the best outcome. Then again, I have no idea what I'm doing, so ¯_(ツ)_/¯.

@jrobles-r7 jrobles-r7 merged commit 93f66a1 into rapid7:master Jan 15, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jrobles-r7 added a commit that referenced this pull request Jan 15, 2019

@jrobles-r7

This comment has been minimized.

Copy link
Contributor

jrobles-r7 commented Jan 15, 2019

No worries. LGTM

msjenkins-r7 added a commit that referenced this pull request Jan 15, 2019

@jrobles-r7

This comment has been minimized.

Copy link
Contributor

jrobles-r7 commented Jan 15, 2019

Release Notes

This updates the KoreLogic option in the JTR modules to an uppercase standard.

@h00die h00die deleted the h00die:uppercase branch Jan 15, 2019

@h00die h00die referenced this pull request Jan 22, 2019

Closed

jtr_* modernizations #11298

0 of 3 tasks complete

@h00die h00die referenced this pull request Jan 25, 2019

Closed

jtr modernizations #11316

0 of 3 tasks complete

@h00die h00die referenced this pull request Feb 3, 2019

Merged

jtr modernizations (again again again) #11351

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment