-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uppercase KoreLogic in JTR modules #11263
Conversation
|
Yup, that's in #11264 . Aix hasn't worked, according to my research, in 5yrs so I don't think this will be a hold up |
Oh ok. Thanks for pointing that out. |
Sorry for the confusion. Originally I started by just working on docs for jtr_*, and while working through it I started noticing a bunch of library-ish stuff that was off, which then started to become one GIANT PR which worked on all jtr modules and the associated libraries, or trying to pick some of it out for smaller PRs. I didn't want to have 2 PRs modifying the same file just in case there was a collision or other unintended issue. But after figuring out aix didn't work at all and hadn't in so long, I figured this would be the best outcome. Then again, I have no idea what I'm doing, so ¯_(ツ)_/¯. |
No worries. LGTM |
Release NotesThis updates the |
This PR standardizes the
KoreLogic
option in the JTR modules to be uppercase.