-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTTP/SMB mixin order to restore SSL option #11330
Conversation
Mixin order matters. Mixins kinda suck.
Options diff pre and post patch
|
include Msf::Exploit::Remote::SMB::Server::Share | ||
include Msf::Exploit::Remote::HttpClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be worth a comment on why this has to come after (even just See #11330) to prevent this from happening in the future
Release NotesThis fixes the HTTP/SMB mixin order to restore the SSL option. Previously, registering the SMB server share mixin after |
Mixin order matters. Mixins kinda suck (the way we use them).
Registering the SMB server share mixin after
HttpClient
deregisters theSSL
andSSLCert
options. They're still settable, but they vanish from the options lists.Reported by @terrorbyte.