-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL CREATE LANGUAGE Execution - Fix version detection #11636
Conversation
I have no idea why the original module used This implies that The original PR (#6417) was extensively reviewed; however the convoluted regex was never questioned. If the PostgreSQL banner can lie about the software, it may also lie about the version. As such, this module could potentially benefit form implementation of a |
Current behavior:
Fixed behavior:
Different error after failed
|
Release NotesThe version detection in the |
This PR fixes the version detection in the PostgreSQL CREATE LANGUAGE Execution module. Fixes #11629
Prior to this PR, the version detection was overly complex and unreliable, causing the
check
method to fail withNoMethodError undefined method `[]' for nil:NilClass
This PR simplifies the version detection to match
^PostgreSQL ([\d\.]+)
.Reviewing the PostgreSQL documentation for version 8/9 indicates that
SELECT version()
returns the version in this format.