Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "search" bug #11763

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Fix "search" bug #11763

merged 1 commit into from
Apr 21, 2019

Conversation

L-codes
Copy link
Contributor

@L-codes L-codes commented Apr 21, 2019

Since module_metadata.notes['AKA'] is not Array caused an error

msf5 > search test
[-] Error while running command search: no implicit conversion of String into Array

@bcoles bcoles added the bug label Apr 21, 2019
@bcoles
Copy link
Contributor

bcoles commented Apr 21, 2019

Confirmed.

msf5 > use auxiliary/gather/rails_doubletap_file_read 
msf5 auxiliary(gather/rails_doubletap_file_read) > info
[-] Error while running command info: undefined method `each' for "DoubleTap":String

Call stack:
/root/Desktop/metasploit-framework/lib/msf/base/serializer/readable_text.rb:682:in `dump_aka'
/root/Desktop/metasploit-framework/lib/msf/base/serializer/readable_text.rb:345:in `dump_auxiliary_module'
/root/Desktop/metasploit-framework/lib/msf/base/serializer/readable_text.rb:32:in `dump_module'
/root/Desktop/metasploit-framework/lib/msf/ui/console/command_dispatcher/modules.rb:132:in `cmd_info'
/root/Desktop/metasploit-framework/lib/rex/ui/text/dispatcher_shell.rb:522:in `run_command'
/root/Desktop/metasploit-framework/lib/rex/ui/text/dispatcher_shell.rb:473:in `block in run_single'
/root/Desktop/metasploit-framework/lib/rex/ui/text/dispatcher_shell.rb:467:in `each'
/root/Desktop/metasploit-framework/lib/rex/ui/text/dispatcher_shell.rb:467:in `run_single'
/root/Desktop/metasploit-framework/lib/rex/ui/text/shell.rb:151:in `run'
/root/Desktop/metasploit-framework/lib/metasploit/framework/command/console.rb:48:in `start'
/root/Desktop/metasploit-framework/lib/metasploit/framework/command/base.rb:82:in `start'
./msfconsole:49:in `<main>'

@bcoles bcoles added the module label Apr 21, 2019
@bcoles bcoles self-assigned this Apr 21, 2019
@bcoles bcoles merged commit 3c237b9 into rapid7:master Apr 21, 2019
@bcoles bcoles added the rn-fix release notes fix label Apr 21, 2019
@bcoles
Copy link
Contributor

bcoles commented Apr 21, 2019

Release Notes

This fixes the Notes hash AKA array in the rails_doubletap_file_read auxiliary module to prevent a syntax error when parsing module info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants