Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-host tab completion to analyze command and fix range truncation bug #11879

Merged
merged 2 commits into from May 23, 2019

Conversation

Projects
None yet
3 participants
@wvu-r7
Copy link
Contributor

commented May 23, 2019

I was forgetting how to dedupe.

msf5 > analyze 192.168.1.
analyze 192.168.1.1  analyze 192.168.1.2
msf5 > analyze 192.168.1.1 192.168.1.2
[*] Analyzing 192.168.1.1...
[*] No suggestions for 192.168.1.1.
[*] Analyzing 192.168.1.2...
[*] No suggestions for 192.168.1.2.
msf5 >

This also fixes a range truncation bug:

msf5 > analyze 192.168.1.1 192.168.1.2
[*] Analyzing 192.168.1.1...
[*] No suggestions for 192.168.1.1.
msf5 >
msf5 > hosts 192.168.1.1 192.168.1.2

Hosts
=====

address      mac  name  os_name  os_flavor  os_sp  purpose  info  comments
-------      ---  ----  -------  ---------  -----  -------  ----  --------
192.168.1.1

msf5 >

Ironically, the incomplete behavior in the previous PR was correct due to a range truncation bug. With the bug fixed, we can now complete more than one host on a line.

Redux of #11878.

@wvu-r7 wvu-r7 requested a review from mkienow-r7 May 23, 2019

@wvu-r7 wvu-r7 changed the title Add smarter (deduped) tab completion to analyze command Add smarter (deduped) tab completion to analyze command and fix range truncation bug May 23, 2019

@wvu-r7 wvu-r7 changed the title Add smarter (deduped) tab completion to analyze command and fix range truncation bug Add multi-host tab completion to analyze command and fix range truncation bug May 23, 2019

@jmartin-r7
Copy link
Contributor

left a comment

hosts and analyze look good to me.

msf5 > hosts 192.168.17.254 192.168.18.118

Hosts
=====

address         mac                name            os_name                            os_flavor  os_sp  purpose  info  comments
-------         ---                ----            -------                            ---------  -----  -------  ----  --------
192.168.17.254                                     Unknown                                              device
192.168.18.118  00:0c:29:6e:e8:7f  VAGRANT-2008R2  Windows 2008 R2, Standard Edition             SP1    server

msf5 > hosts

Hosts
=====

address         mac                name            os_name                            os_flavor  os_sp  purpose  info  comments
-------         ---                ----            -------                            ---------  -----  -------  ----  --------
192.168.17.254                                     Unknown                                              device
192.168.18.118  00:0c:29:6e:e8:7f  VAGRANT-2008R2  Windows 2008 R2, Standard Edition             SP1    server

msf5 > analyze 192.168.1
analyze 192.168.17.254  analyze 192.168.18.118
msf5 > analyze 192.168.18.118 192.168.1
analyze 192.168.18.118 192.168.17.254  analyze 192.168.18.118 192.168.18.118
msf5 > analyze 192.168.18.118 192.168.17.254
[*] Analyzing 192.168.18.118...
[*] exploit/windows/smb/ms17_010_eternalblue
[*] exploit/windows/smb/ms17_010_eternalblue_win8
[*] exploit/windows/smb/ms17_010_psexec
[*] Analyzing 192.168.17.254...
[*] No suggestions for 192.168.17.254.
msf5 >

@jmartin-r7 jmartin-r7 merged commit bea3659 into rapid7:master May 23, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details

jmartin-r7 added a commit that referenced this pull request May 23, 2019

@wvu-r7 wvu-r7 deleted the wvu-r7:feature/analyze branch May 23, 2019

@wvu-r7

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

Thanks for the review, too!

jmartin-r7 added a commit that referenced this pull request May 24, 2019

@tdoan-r7 tdoan-r7 added the rn-fix label Jun 4, 2019

@tdoan-r7

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Release Notes

This fix addresses an issue with range truncation that affected multi-host tab completion for the analyze command. You can now complete more than one host on a line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.