Add multi-host tab completion to analyze command and fix range truncation bug #11879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvu
changed the title
wvu
changed the title
jmartin-tech
approved these changes
May 23, 2019
There was a problem hiding this comment.
hosts and analyze look good to me.
msf5 > hosts 192.168.17.254 192.168.18.118
Hosts
=====
address mac name os_name os_flavor os_sp purpose info comments
------- --- ---- ------- --------- ----- ------- ---- --------
192.168.17.254 Unknown device
192.168.18.118 00:0c:29:6e:e8:7f VAGRANT-2008R2 Windows 2008 R2, Standard Edition SP1 server
msf5 > hosts
Hosts
=====
address mac name os_name os_flavor os_sp purpose info comments
------- --- ---- ------- --------- ----- ------- ---- --------
192.168.17.254 Unknown device
192.168.18.118 00:0c:29:6e:e8:7f VAGRANT-2008R2 Windows 2008 R2, Standard Edition SP1 server
msf5 > analyze 192.168.1
analyze 192.168.17.254 analyze 192.168.18.118
msf5 > analyze 192.168.18.118 192.168.1
analyze 192.168.18.118 192.168.17.254 analyze 192.168.18.118 192.168.18.118
msf5 > analyze 192.168.18.118 192.168.17.254
[*] Analyzing 192.168.18.118...
[*] exploit/windows/smb/ms17_010_eternalblue
[*] exploit/windows/smb/ms17_010_eternalblue_win8
[*] exploit/windows/smb/ms17_010_psexec
[*] Analyzing 192.168.17.254...
[*] No suggestions for 192.168.17.254.
msf5 >
|
Thanks for the review, too! |
Release NotesThis fix addresses an issue with range truncation that affected multi-host tab completion for the analyze command. You can now complete more than one host on a line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was forgetting how to dedupe.
This also fixes a range truncation bug:
Ironically, the incomplete behavior in the previous PR was correct due to a range truncation bug. With the bug fixed, we can now complete more than one host on a line.
Redux of #11878.