Use correct case for SSL option

[egypt]

Fix redirection to an HTTPS url from an HTTP url.

Verification

List the steps needed to make sure this thing works

make an aux module with a run method like

def run_host(ip)
       response = send_request_cgi!(                                                                                                                                                                            
         opts={'uri' => '/admin', 'method' => 'GET' }, 5, 5                                                                                                                                                     
       )                                                                                                                                                                                                        
       p opts                                                                                                                                                                                                   
end

• Find or make a webserver that 302's to an https URL.
• Verify the outputted opts['SSL'] is true
• Verify redirect is followed as expected

[busterb]

There's another one up here right?

[egypt]

I think this line is basically a no-op because it will never differ from the previous request.

[busterb]

The oddity also is that send_request_cgi says:

# Passesopts through directly to {Rex::Proto::Http::Client#request_cgi}.

and Rex::Proto::Http::Client also uses opts['ssl'] lowercase, or at least sets that internally, but maybe that value not actually used, and instead it's self.ssl? Seems like those would also be upper-case converted. Agree this fixes a bug, but maybe a few others scurry out of the light when looking at this closer!

[sempervictus]

This is handled, usually, by Socket:: Parameters, which IIRC will take both upper and lowercase for this. Need to double check that, as my recollection is from params refactoring for sslclient params a while back.

[egypt]

Travis error looks like an unrelated network problem on Travis's end.

[busterb]

Added bd90241 for consistency within the function, even if is a no-op.

[busterb]

Release Notes

This fixes redirection to an HTTPS url from an HTTP url with the HTTP client library.