Fix Python reverse_http & reverse_https #12443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in Python's
reverse_http
andreverse_https
stagers. There's an issue where if the size is not large enough1 to store the UUID that the UUID will be omitted2, causing the stager to fail to transfer and load.This increases the size from 5 to 30, to allow the UUID to be included and then updates the payload's cached size. The bug affects both the HTTP and HTTPS versions due to the code reuse.
Verification
msfconsole
use payload/python/meterpreter/reverse_http
to_handler
to start a handlergenerate -f raw
to get the stagerOriginal (Broken) Output
This bug seems to have been related to commit 5621d20.