Consolidate workspace actions #12457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When renaming a workspace allow validation to handle all cases the same * Do not display backtrace on console for rename failure, this is still logged to framework.log
jmartin-tech
force-pushed
the
consolidate-workspace-action
branch
from
580c481
to
7505e1b
Compare
jmartin-tech
commented
Oct 15, 2019
| default_renamed = true if ws_to_update.name == DEFAULT_WORKSPACE_NAME | ||
| updated_ws = ws_to_update.update!(opts) |
There was a problem hiding this comment.
This line prompted this change as update!() actually returns a boolean not the workspace object.
Release NotesThis revises how workspace operations, particularly renames, are handled in Metasploit 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification
List the steps needed to make sure this thing works
msfconsoleworkspace -r default testworkspace -r default test