Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate workspace actions #12457

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@jmartin-r7
Copy link
Contributor

jmartin-r7 commented Oct 15, 2019

  • When renaming a workspace allow validation to handle all cases the same
  • Do not display backtrace on console for rename failure, this is still logged to framework.log

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • workspace -r default test
  • workspace -r default test
  • Verify a simple error message reports that rename could not validate as the workspace name is already taken
* When renaming a workspace allow validation to handle all cases the same
* Do not display backtrace on console for rename failure, this is still logged to framework.log
@jmartin-r7 jmartin-r7 force-pushed the jmartin-r7:consolidate-workspace-action branch from 580c481 to 7505e1b Oct 15, 2019
default_renamed = true if ws_to_update.name == DEFAULT_WORKSPACE_NAME
updated_ws = ws_to_update.update!(opts)

This comment has been minimized.

Copy link
@jmartin-r7

jmartin-r7 Oct 15, 2019

Author Contributor

This line prompted this change as update!() actually returns a boolean not the workspace object.

@busterb busterb self-assigned this Nov 19, 2019
bcook-r7 pushed a commit that referenced this pull request Nov 19, 2019
@bcook-r7 bcook-r7 merged commit 7505e1b into rapid7:master Nov 19, 2019
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@busterb

This comment has been minimized.

Copy link
Member

busterb commented Nov 19, 2019

Release Notes

This revises how workspace operations, particularly renames, are handled in Metasploit 5.

fengjixuchui added a commit to fengjixuchui/metasploit-framework that referenced this pull request Nov 20, 2019
Land rapid7#12457, consolidate workspace actions
@jmartin-r7 jmartin-r7 deleted the jmartin-r7:consolidate-workspace-action branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.