Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports need workspace #12459

Merged
merged 2 commits into from Oct 17, 2019

Conversation

@jmartin-r7
Copy link
Contributor

jmartin-r7 commented Oct 15, 2019

When importing credentials Metasploit::Credential::Importer classes expect to receive an Mdm::Workspace.

Also when executing report* methods during xml import the workspace is a required fact.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • workspace -a first_import
  • db_import pwdump.txt
  • Verify the creds import
  • workspace -a second_import
  • db_import nexpose_simple_xml_3hosts.xml
  • Verify the host and vuln details reported are in the correct workspace.
jmartin-r7 added 2 commits Oct 15, 2019
Metasploit::Credential importers expect an Mdm::Workspace object.
The report methods of the db layer require the workspace during import.
@mkienow-r7

This comment has been minimized.

Copy link
Contributor

mkienow-r7 commented Oct 17, 2019

The code LGTM. Confirmed Metasploit::Credential::Importer::Base is expecting a Mdm::Workspace rather than the name string.

@mkienow-r7 mkienow-r7 added the creds label Oct 17, 2019
@pbarry-r7 pbarry-r7 self-requested a review Oct 17, 2019
@pbarry-r7

This comment has been minimized.

Copy link
Contributor

pbarry-r7 commented Oct 17, 2019

Tested fine! 👏

jmartin-r7 added a commit that referenced this pull request Oct 17, 2019
@jmartin-r7 jmartin-r7 merged commit 289a9c5 into rapid7:master Oct 17, 2019
3 checks passed
3 checks passed
Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmartin-r7 jmartin-r7 deleted the jmartin-r7:imports-need-workspace branch Oct 17, 2019
fengjixuchui added a commit to fengjixuchui/metasploit-framework that referenced this pull request Oct 18, 2019
Land rapid7#12459, Imports need workspace
@jmartin-r7

This comment has been minimized.

Copy link
Contributor Author

jmartin-r7 commented Oct 25, 2019

Release Notes

Fixes a stack trace when importing credential files from pwdump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.