Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports need workspace #12459

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Imports need workspace #12459

merged 2 commits into from
Oct 17, 2019

Conversation

jmartin-tech
Copy link
Contributor

@jmartin-tech jmartin-tech commented Oct 15, 2019 •
edited by pbarry-r7
Loading

When importing credentials Metasploit::Credential::Importer classes expect to receive an Mdm::Workspace.

Also when executing report* methods during xml import the workspace is a required fact.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • workspace -a first_import
  • db_import pwdump.txt
  • Verify the creds import
  • workspace -a second_import
  • db_import nexpose_simple_xml_3hosts.xml
  • Verify the host and vuln details reported are in the correct workspace.

@jmartin-tech
cred imports need a workspace object passed to lib
b494bf5 
Metasploit::Credential importers expect an Mdm::Workspace object.
@jmartin-tech
when making requests to report send workspace
289a9c5 
The report methods of the db layer require the workspace during import.
@mkienow-r7
Copy link
Contributor

The code LGTM. Confirmed Metasploit::Credential::Importer::Base is expecting a Mdm::Workspace rather than the name string.

@pbarry-r7 pbarry-r7 self-requested a review October 17, 2019 21:43
@pbarry-r7
Copy link
Contributor

Tested fine! 👏

jmartin-tech added a commit that referenced this pull request Oct 17, 2019
@jmartin-tech
Land #12459, Imports need workspace
b2c753d
@jmartin-tech jmartin-tech merged commit 289a9c5 into rapid7:master Oct 17, 2019
@jmartin-tech jmartin-tech deleted the imports-need-workspace branch October 17, 2019 22:02
@jmartin-tech
Copy link
Contributor Author

Release Notes

Fixes a stack trace when importing credential files from pwdump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbarry-r7 pbarry-r7 Awaiting requested review from pbarry-r7

Assignees
No one assigned
Labels
creds database library msf5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmartin-tech @mkienow-r7 @pbarry-r7