Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporting creds can have linked task #12663

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

jmartin-tech
Copy link
Contributor

@jmartin-tech jmartin-tech commented Dec 4, 2019

When reporting creds the credential model will link to a task provided by task_id.

Verification

List the steps needed to make sure this thing works

@jmartin-tech
Copy link
Contributor Author

Future changes may be desired to pass the Task itself and update metasploit-credential gem as a breaking api change.

@h00die
Copy link
Contributor

h00die commented Dec 5, 2019

does this solve h00die#13 as well?

@jmartin-tech
Copy link
Contributor Author

@h00die unfortunately not the task is not involved in h00die#13, however since I am working in that area I have things setup to be able to dig into that more now.

@pbarry-r7 pbarry-r7 self-assigned this Dec 6, 2019
@pbarry-r7
Copy link
Contributor

Testing via the examples in the module docs in #11695 looks good! 👏

Are we concerned about the Travis failures related to "swtich" device spec credentials tests...?

@jmartin-tech
Copy link
Contributor Author

Sorry missed those... looks like tests need update will complete shortly.

@pbarry-r7
Copy link
Contributor

All looks good, will land...!

pbarry-r7 added a commit that referenced this pull request Dec 6, 2019
@pbarry-r7 pbarry-r7 merged commit 2106003 into rapid7:master Dec 6, 2019
@pbarry-r7
Copy link
Contributor

Release Notes

When reporting creds, also set the associated task_id if one is present.

@jmartin-tech jmartin-tech deleted the pass-task-to-db branch November 17, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants