-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update removal commands for osx/local/persistence #12871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit. LGTM
These changes look OK but I'm not having much success with this module on Mojave:
I'll merge this and fix 1., and hopefully figure out what's going on with 2. |
Despite 2. the module still appears to work once I reboot 🤷♂️ |
AFAIK the load command only loads immediately the script but the persistence is achieved by writing the .plist itself. |
Please see: 0b0d4c8
Thanks @phra !! |
Release NotesFixes module osx/local/persistence. Previously it suggested the wrong removal commands that prevented the deletion of the dropped executable. |
fixes #12870