Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP-FPM RCE module issue when calling check and exploit multiple times #13038

Merged
merged 1 commit into from Mar 6, 2020

Conversation

cdelafuente-r7
Copy link
Contributor

The client is left connected after calling check, whereas it is successful or not. This causes the exploit to fail when calling exploit next.

This fix simply ensure the client is always disconnected when leaving the check method.

Copy link
Contributor

@smcintyre-r7 smcintyre-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I'm going to test this and land it once I verify it fixes the issue.

@smcintyre-r7 smcintyre-r7 merged commit c757803 into rapid7:master Mar 6, 2020
@smcintyre-r7 smcintyre-r7 added the rn-no-release-notes no release notes label Mar 6, 2020
@smcintyre-r7
Copy link
Contributor

Verified this fixed the issue. I'm no longer getting IO / Connection errors when running exploit immediately after check. Thanks @cdelafuente-r7 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants