Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding alias of ftp_connect #13093

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Conversation

mdisec
Copy link
Contributor

@mdisec mdisec commented Mar 18, 2020

Signed-off-by: Mehmet İnce mehmet@mehmetince.net

This PR solves issue mention at #13090 . This PR solved a method name collusions specially that occurs when Msf::Exploit::Remote::HttpClient and Msf::Exploit::Remote::Ftp included in same module.

Of course I am open to discuss different approaches 👍🏻

Cheers.

Signed-off-by: Mehmet İnce <mehmet@mehmetince.net>
@wvu wvu self-assigned this Mar 23, 2020
@wvu wvu added bug mixin madness When mixins misbehave labels Mar 23, 2020
@wvu wvu removed their assignment Mar 26, 2020
@wvu
Copy link
Contributor

wvu commented Mar 26, 2020

This has been transferred to the Belfast team. Thanks.

@adfoster-r7 adfoster-r7 self-assigned this Mar 30, 2020
@adfoster-r7 adfoster-r7 merged commit 60114d3 into rapid7:master Mar 30, 2020
@adfoster-r7 adfoster-r7 added the rn-enhancement release notes enhancement label Mar 30, 2020
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Mar 30, 2020

Release notes

This adds an alias of ftp_connect to connect within Exploit::Remote::Ftp. This addition helps solves name collisions when Msf::Exploit::Remote::HttpClient and Msf::Exploit::Remote::Ftp are included in the same module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug library mixin madness When mixins misbehave rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants