YAML warnings are very unnecessary, they can only do harm #13250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MSF5 we've said 'WARNING' with print_error about an issue a lot of users don't really care about (whether there's a database.yaml). While they lose some functionality, it anecodtally doesn't seem to make a whole lot of difference in anyone's behavior, but does cause noise in the issue queue when folks don't understand, especially with Windows installations. Let's conserve a few bits of entropy in the universe and switch these warning messages to be logged as warnings (which are quiet by default).
Verification
msfconsole
without a database YAML file