-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OptAddressLocal for SRVHOST to specify by interface name instead of IP #13405
Conversation
I was slightly worried that this might prevent users from opening listening sockets via sessions but after some preliminary testing, that does not look like it is the case. |
This looks like a good change! |
|
@Kynepups I think you didn't paste the correct thing or you're in the wrong issue 😉 |
Thanks for doing this, actually. The option hasn't seen much use since its inception (I think it was actually created for Pro). This addresses the primary use case in Framework. |
Correct. See prior comment. |
I'm linking issues for posterity. |
(yes sorry I was too fast, deleted mine) |
I'm kind of amazed this didn't happen sooner, but I think we were trying to avoid regressions in a new feature. That was years ago by now. So this is a good upgrade. |
Yes preventing regressions is the main concern... I guess we'll see? :) |
As for your to-dos, I think we can tweak the description a bit, and it should be "globalized" enough, since it's in |
Co-authored-by: wvu-r7 <wvu-r7@users.noreply.github.com>
Co-authored-by: wvu-r7 <wvu-r7@users.noreply.github.com>
Cool, will wait for build to pass and then merge. I'll work on your other PRs in the meantime. :) |
Release NotesThis converts the |
Okay... "did you solve problem master??"
…On Wednesday, May 13, 2020, ♄ ***@***.***> wrote:
Merged #13405 <#13405>
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJWWUQEIGRVRWV5MQMCQZS3RRLGIRANCNFSM4M2VIYIQ>
.
|
@Kynepups if you have an issue to report, I suggest creating a separate issue on https://github.com/rapid7/metasploit-framework/issues and provide more information as suggested. Your previous messages aren't very explicit... |
thanks
… @Kynepups <https://github.com/Kynepups> if you have an issue to report, I
suggest creating a separate issue on https://github.com/rapid7/
metasploit-framework/issues and provide more information as suggested.
Your previous messages aren't very explicit...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJWWUQGFUE2ZIVOCK6W7XRTRRLOPVANCNFSM4M2VIYIQ>
.
|
Thanks to #8336 we can now specify LHOST by interface name instead of IP which is really nice.
I got this habit and now I want to apply it to SRVHOST too :)
Verification
msfconsole -x "use windows/smb/smb_delivery; set srvhost eth0; set payload windows/meterpreter/reverse_tcp; set lhost eth0; run"
[*] Started service listener on 192.168.42.100:445
TODO:
I will gladly do these remaining tasks if you like this PR :)