PR to fix two modules for CVE-2020-12720 not properly handling vBulletin table prefixes #13553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling cases where a table prefix was not used, this guard clauses was redundant in that the one inside the get_table_prefix method is already checking the result of the SQL injection performed.
Zenofex
changed the title
smcintyre-r7
approved these changes
Jun 3, 2020
Release NotesThis fixes redundant guard clauses in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug disclosed to me about my 2 modules leveraging CVE-2020-12720 (
gather/vbulletin_getindexablecontent_sqli&multi/http/vbulletin_getindexablecontent) . Specifically in the functionality used to determine the table prefixes for the vBulletin install. The fix supplied in this PR removes the guard clause outside of the get_table_prefix function, which is actually semi-redundant in that the results of the SQLi attack are checked within the get_table_prefix method.Verification
Testing Exploit Module
msfconsoleuse exploit/multi/http/vbulletin_getindexablecontentset RHOSTS [IP]set VHOST [HOSTNAME]set TARGETURI [PATH]checkrunTesting Auxillary Module
msfconsoleuse auxiliary/gather/vbulletin_getindexablecontent_sqliset RHOSTS [IP]set VHOST [HOSTNAME]set TARGETURI [PATH]run