Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fail_with from check method #13859

Merged
merged 1 commit into from Jul 22, 2020

Conversation

bcoles
Copy link
Contributor

@bcoles bcoles commented Jul 18, 2020

Remove fail_with call from check method in exim4_deliver_message_priv_esc module as this was crashing the local exploit suggester module. Resolves #13850.

Also slightly improves the module logic. The module falsely believed that the only two session types are shell or meterpreter. This ignores ssh and is not future-proof. This PR modifies the logic to check for session.type != 'meterpreter' instead of session.type == 'shell'.

@adfoster-r7 adfoster-r7 merged commit d34ab2b into rapid7:master Jul 22, 2020
@adfoster-r7 adfoster-r7 added the rn-enhancement release notes enhancement label Jul 22, 2020
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Jul 22, 2020

Release Notes

Removed fail_with() call from check method in the exim4_deliver_message_priv_esc module, as this was crashing the local exploit suggester module.

@bcoles bcoles deleted the exim4_deliver_message_priv_esc branch July 22, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug easy rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Exploit Suggest Module - Failed bash not found
2 participants