Remove fail_with from check method #13859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
fail_with
call fromcheck
method inexim4_deliver_message_priv_esc
module as this was crashing the local exploit suggester module. Resolves #13850.Also slightly improves the module logic. The module falsely believed that the only two session types are
shell
ormeterpreter
. This ignoresssh
and is not future-proof. This PR modifies the logic to check forsession.type != 'meterpreter'
instead ofsession.type == 'shell'
.