Ignore tests when reloading files

[adfoster-r7]

Before

When spec files are changed, this causes issues with the reload_lib command:

msf6 exploit(windows/smb/psexec) > echo ' ' >> spec/lib/msf/core/author_spec.rb
[*] exec: echo ' ' >> spec/lib/msf/core/author_spec.rb

msf6 exploit(windows/smb/psexec) > reload_lib -a
[*] Reloading /Users/adfoster/Documents/code/metasploit-framework/spec/lib/msf/core/author_spec.rb
[-] Error while running command reload_lib: cannot load such file -- spec_helper

After

The reload_lib command works, ignoring spec file changes:

msf6 exploit(windows/smb/psexec) > echo ' ' >> spec/lib/msf/core/author_spec.rb
[*] exec: echo ' ' >> spec/lib/msf/core/author_spec.rb

msf6 exploit(windows/smb/psexec) > reload_lib -a
msf6 exploit(windows/smb/psexec) >

Verification

List the steps needed to make sure this thing works

• Modify an arbitrary spec file: echo ' ' >> spec/lib/msf/core/author_spec.rb
• Start msfconsole
• reload_lib -a
• Verify there is no crash

[gwillcox-r7]

Confirmed this is an issue before the patch:

msf6 > echo ' ' >> spec/lib/msf/core/author_spec.rb
[*] exec: echo ' ' >> spec/lib/msf/core/author_spec.rb

msf6 > reload_lib -a
[*] Reloading /home/gwillcox/git/metasploit-framework/spec/lib/msf/core/author_spec.rb
[-] Error while running command reload_lib: cannot load such file -- spec_helper
msf6 > exit

After patch:

msf6 > echo ' ' >> spec/lib/msf/core/author_spec.rb
[*] exec: echo ' ' >> spec/lib/msf/core/author_spec.rb

msf6 > reload_lib -a
msf6 >

Code also looks good, will land this in so long.

[gwillcox-r7]

Release Notes

Improved the Framework reload-changed-files logic to skip RSpec test files. Previously, commands like reload_lib -a would return an error attempting to load these test files.