Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "does not exists" to "does not exist" except in vendors file #14024

Closed
wants to merge 1 commit into from

Conversation

coreyprevost
Copy link

@coreyprevost coreyprevost commented Aug 19, 2020

Fixes #14020
Replaces "does not exists" with "does not exist" across the framework

@coreyprevost
Copy link
Author

Changed "does not exists" to "does not exist" except in vendors file #14020

@adfoster-r7 adfoster-r7 added the needs-unique-branch The pull request must not be from the master branch label Aug 21, 2020
@label-actions
Copy link

label-actions bot commented Aug 21, 2020

Thanks for your pull request! We require for all contributed code to come from a from a unique branch in your repository before it can be merged.

Please create a new branch in your fork of framework and resubmit this from that branch.

If you are using Git on the command line that may look like:

# Checkout the master branch
git checkout master

# Create a new branch for your feature
git checkout -b <BRANCH_NAME>

# Add your new files
git add modules/my-cool-new-module

# Commit your changes with a relevant message
git commit

# Push your changes to GitHub
git push origin <BRANCH_NAME>

# Now browse to the following URL and create your pull request!
# - https://github.com/rapid7/metasploit-framework/pulls

This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed.

Please do resubmit from a unique branch, we greatly value your contribution! 🎉

@label-actions label-actions bot closed this Aug 21, 2020
@h00die
Copy link
Contributor

h00die commented Oct 7, 2020

@coreyprevost were you still interested in getting this PR working? It would only take you a minute or two to fix up some of the spelling/grammar! just follow the instructions in the label-actions bot comment.

@coreyprevost
Copy link
Author

coreyprevost commented Oct 7, 2020 via email

@gwillcox-r7
Copy link
Contributor

@coreyprevost Any update on this? Are you still planning to open a new PR?

@h00die
Copy link
Contributor

h00die commented Nov 29, 2020

@coreyprevost just checking in again on this.

@CSharperMantle
Copy link
Contributor

CSharperMantle commented Dec 23, 2020

PR sent in the hope of fixing branch-related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-unique-branch The pull request must not be from the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all the "does not exists"
6 participants