rescue SSLError in HTTP scanner check_setup

[jmartin-tech]

By capturing possible connection errors when SSL cannot be
negotiated, this update prevents early exit due to failure of a
single IP when scanning a range of IPs

Verification

List the steps needed to make sure this thing works

• Start msfconsole
• use an https based login_scanner to scan a host with the service unable to offer SSL support
• Verify module completes
• Verify no exception occurs

Note: there are at least 10 other known overrides of check_setup that do not rescue any errors. Due to inconsistent behaviors for these methods, scope has been limited to get a start on improvements.

[bwatters-r7]

Is there an issue associated with this bug?

[jmartin-tech]

The original bug is seen in Pro when attempting a brute force run and the unhandled error raises further than expected.

The behavior change can be seen in testing with scanner/http/zabbix_login against a metasploitable3 target:
Before:

msf6 auxiliary(scanner/http/zabbix_login) > run

[*] Error: XX.XX.XX.XX: OpenSSL::SSL::SSLError SSL_connect returned=1 errno=0 state=SSLv2/v3 read server hello A: sslv3 alert handshake failure
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed

After:

msf6 auxiliary(scanner/http/zabbix_login) > run

[-] XX.XX.XX.XX:8443 - Unable to connect to target
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed

[dwelch-r7]

Release Notes

Updated rescue clauses to handle SSLError in HTTP scanner check_setup() methods.

[bnlshtl13]

When I do the PDF file with the following commands, 1- use exploits/android/fileformat/adobe_reader_pdf_js_interface.rb 2- set -p android/meterpreter/reverse_tcp 3- set lhost ip 4- set lport port what are now making to open a session that tapes the PDF file that you have previously created, and I use the Termux program بتاريخ ٢٩‏/١٠‏/٢٠٢٠ ٤:٣٨ م، كتب "dwelch-r7" <notifications@github.com>:

…

Release Notes This PR adds a rescue for SSLError in HTTP scanner check_setup — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14225 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APFI74LVYFSJ5ILG7URZQ5DSNFV5PANCNFSM4SGHDN3A> .