docs and rubocop for several post/windows/gather modules #14258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Oct 19, 2020
adfoster-r7
reviewed
Oct 19, 2020
| @@ -73,6 +73,7 @@ def get_members(results) | |||
|
|
|||
| # Usernames start somewhere around line 6 | |||
| results = results.slice(6, results.length) | |||
| return members if results.nil? | |||
|
Original Release Notes Adds documentation and code quality changes to the following modules:
|
Release NotesImproved module code and added module docs for a number of Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds docs and rubocop for:
modules/post/windows/gather/lsa_secrets.rb also now stores the secrets, optionally, in the database as creds.
windows/gather/enum_domain_group_users.rb had nil loop bug if no users were in the group, so I fixed that crash.