Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move mercury_login.md to docs folder #14296

Merged
merged 1 commit into from Oct 22, 2020
Merged

move mercury_login.md to docs folder #14296

merged 1 commit into from Oct 22, 2020

Conversation

h00die
Copy link
Contributor

@h00die h00die commented Oct 21, 2020

While working on other modules I noted this doc was in the wrong folder. Simply move it where it needs to go so I can finish other things.

Copy link
Contributor

@bcoles bcoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but the documentation format might make h00die sad.

# ./tools/dev/msftidy_docs.rb modules/exploits/windows/imap/mercury_login.md 
modules/exploits/windows/imap/mercury_login.md - [WARNING] Docs should start with ## Vulnerable Application
modules/exploits/windows/imap/mercury_login.md - [WARNING] Missing Section: ## Verification Steps
modules/exploits/windows/imap/mercury_login.md - [WARNING] Missing Section: ## Options
modules/exploits/windows/imap/mercury_login.md - [WARNING] H2 headings in incorrect order. Should be: Vulnerable Application, Verification Steps, Options, Scenarios
modules/exploits/windows/imap/mercury_login.md:1 - [WARNING] Line too long (159). Consider a newline (which resolves to a space in markdown) to break it up around 140 characters.
modules/exploits/windows/imap/mercury_login.md:5 - [WARNING] Line too long (250). Consider a newline (which resolves to a space in markdown) to break it up around 140 characters.

@h00die
Copy link
Contributor Author

h00die commented Oct 22, 2020

it'll join a LONG list of docs which are not up to spec

@bcoles bcoles self-assigned this Oct 22, 2020
@bcoles bcoles merged commit 6258d5b into rapid7:master Oct 22, 2020
@bcoles bcoles added the rn-no-release-notes no release notes label Oct 22, 2020
@bcoles
Copy link
Contributor

bcoles commented Oct 22, 2020

Added rn-no-release-notes as we don't have a release notes label for docs. I delegate responsibility for the release notes to whoever disagrees.

@h00die h00die deleted the move_doc branch October 24, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants