Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused netware console session #14373

Merged
merged 1 commit into from Nov 12, 2020

Conversation

dwelch-r7
Copy link
Contributor

@dwelch-r7 dwelch-r7 commented Nov 10, 2020

This PR is just to remove the netware console session, it's not being used within framework, came across it during the zeitwerk PR and noticed the namespacing was wrong anyway (Sessions vs. Session) so rather than fix it I decided to just remove it as a separate PR to avoid confusion

  • Double check that there are no references to netware console in framework
  • Double check that there are no references to netware console in pro

@adfoster-r7
Copy link
Contributor

Just wanted to confirm that this isn't being used by as part of any meta programming? 👀

From checking Git it looks like it was first added as part of this larger commit:
6677beb#diff-b5ebe5524a6c9c5a205c5da4f37720a12489644dd04bad8fb013ef0b81992994R13

Were the payload was also created:
6677beb#diff-7bffdb6e41e75a95b08ab02d71dd94c080677662b43398f838ca3fcbdec7c5e1R18

Which still exists in the codebase today, but with its name being updated:

The initial commit doesn't have any static references to NetwareConsole either, so it was either introduced as dead code, or there's meta programming involved, or I'm missing something obvious 😄

As an aside, it looks like this software and company no longer exist - it might be appropriate to delete this its entirety?

@agalway-r7
Copy link
Contributor

From the wikipedia article on Netware:

The final update release was version 6.5SP8 of May 2009; NetWare is no longer on Novell's product list. NetWare 6.5SP8 General Support ended in 2010, with Extended Support until the end of 2015, and Self Support until the end of 2017. The replacement is Open Enterprise Server.

So no type of support for three years, a modern replacement every user will have hopped over to, and a check on master that backs up NetwareConsole isn't being used anywhere has me happy to nuke this from framework. I will look through Pro now.

@agalway-r7
Copy link
Contributor

Pro's all good, merging

@agalway-r7 agalway-r7 merged commit 04398b5 into rapid7:master Nov 12, 2020
@agalway-r7
Copy link
Contributor

agalway-r7 commented Nov 12, 2020

Release Notes

Removed unused NetwareConsole Session from the codebase.

@agalway-r7 agalway-r7 added the rn-enhancement release notes enhancement label Nov 12, 2020
@dwelch-r7 dwelch-r7 deleted the remove-netware-console branch January 18, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants