Fixes rhost_http_url crashes when running the check method #14381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Resolves #14308.
The crash was previously caused when the user enabled
features set RHOST_HTTP_URL true
, then when the check method is ran, it would crash and return this error message.Example of crash:
This was caused due to a hash being passed in as
value
insingle_rhost?(value)
. The fix now checks if value is a hash inget_uri
and sets it appropriately before it gets passed tosingle_rhost?(value)
.Options used to recreated issue:
Verification
Set-up for testing:
I edited my
/etc/hosts
to containTest steps:
msfconsole
features set RHOST_HTTP_URL true
use exploit/unix/webapp/wp_admin_shell_upload