Add configurable logging to the console and support stdout sinks #14431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to the rather specific implementation of Add stdout logging functionality to json rpc, this PR adds a configuration option to the console and the rpc service for specifying the required metasploit logsink
Verification
Console verification
Verify that default logging works, and the default Flatfile sink works as expected:
Ensure that the logger can be configured with arbitrary loggers:
For example, the stdout/stderr loggers should resemble:
The Flatfile loggers will go to
~/.msf4/logs/framework.log
as normal.Additionally verifying invalid options work:
JSON RPC support
This functionality is additionally supported by the rpc layer:
Curling with an additional request:
Verifying the server's output: