Zeitwerk msf folder

[dwelch-r7]

Continuation of the zeitwerk initiative we have going on, following on from this pr #14202 and #14584

In this PR we have zeitwerked the lib/msf/ folder

Verification steps

• All framework tests pass
• Metasploit Pro tests pass

On Linux

• Console boots up
• search for and use a module
• Sucessfully run a module
• Generate a payload with msfvenom
• Gain a meterpreter session

On Osx

• Console boots up
• search for and use a module
• Sucessfully run a module
• Generate a payload with msfvenom
• Gain a meterpreter session

On Windows

• Console boots up
• search for and use a module
• Sucessfully run a module
• Generate a payload with msfvenom
• Gain a meterpreter session

[adfoster-r7]

Sanity question, is this needed still?

[dwelch-r7]

it shouldn't be, it only seems to affect any strings defined in the file and there aren't any 😄
weren't any before so it was probably a copy/paste job

[adfoster-r7]

That's my understanding too, just calling it out for visibility - as there seemed to be a couple of historical bulk changes to add this to every file:
d656e31

I imagine there was a solid reason for it that, but the commit doesn't have any further details. It could've just been the easiest to automate, adding any missing binary comment regardless of the file's content

[adfoster-r7]

These comments have been useful in the past, does it make sense to move it elsewhere? 🤔

Since we plan on deleting this file - I'm not sure where it would live within our code. I've seen some projects have readme.md files in directories of interest, which act as a bread crumb trail as to what the folders are meant to do at the conceptual level. I don't believe having it in the wiki is the right solution either, as the documentation being colocated with the folder will be naturally found when code spelunking

This comment applies to the previously deleted base.rb comments too

[dwelch-r7]

Personally I don't see a tonne of value in these comments but I'd definitely be down for the readme idea if we can keep it up to date

[adfoster-r7]

Trying to restart msfdb:

bundle exec ruby ./msfdb restart
Traceback (most recent call last):
./msfdb:30:in `<main>': uninitialized constant Msf::Config (NameError)
Did you mean?  RbConfig

[dwelch-r7]

Trying to restart msfdb:

bundle exec ruby ./msfdb restart
Traceback (most recent call last):
./msfdb:30:in `<main>': uninitialized constant Msf::Config (NameError)
Did you mean?  RbConfig

Hmmm I thought I fixed that, let me take a look