ensure selected cracker is available and viable #14669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no password cracker is installed
cracker_version
returnsnil
.Guard against
nil
in the version check and consolidate detection ofa viable environment and application as a responsibility of the factory
that provides the instance.
Verification
List the steps needed to make sure this thing works
msfconsole
on a system withoutjohn
orhashcat
installed and a empty database availabledb_disconnect
use crack_linux
(or any otherauxiliary/analyze/crack_*
module)run
msfconsole
on a system withoutjohn
orhashcat
installeddb_connect
use crack_linux
run
john
withoutjumbo
patchuse crack_linux
run
jumbo
patch is required.john
withjumbo
patchuse crack_linux
run
use crack_linux
set action hashcat
run
hashcat
use crack_linux
set action hashcat
run