Add missing requires for socks proxy #14812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcintyre-r7
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Tested successfully with curl using the --socks5 flag. Thanks @dwelch-r7 ! I'll have this merged in shortly.
gwillcox-r7
changed the title
Release NotesRestored missing requires statement for sock5 proxy support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14793
Adds a missing requires for
rex/proto/proxy/socks5/packetinserver_client.rbzeitwerk didn't work in this case since there were multiple classes in that file and zeitwerk is only aware of the one matching the file name (ServerClient in this case)
Verification
use auxiliary/server/socks_proxyrunproxychains curl http://google.com