Allow search to start from root path

[space-r7]

If a user is running a meterpreter session on a non-Windows OS, the search functionality cannot start a
search from the root directory because msf strips the file separator from the input used to create a
search request. Because of this, meterpreter will default to the current working directory and produce
less results than expected or none at all.

This change just makes sure that the search root is not / before chomping the file separator. This also
fixes a typo in the search help output.

Before change

meterpreter > search -f *.lib -d /
No files matching your search were found.

After change

meterpreter > search -f *.lib -d /
Found 6 results...
    /usr/src/linux-headers-4.18.0-15/scripts/Makefile.lib (14968 bytes)
    /usr/src/linux-hwe-5.4-headers-5.4.0-62/scripts/Makefile.lib (15026 bytes)
    /usr/src/linux-headers-5.4.0-65-generic/scripts/Makefile.lib (15026 bytes)
    /usr/src/linux-hwe-5.4-headers-5.4.0-65/scripts/Makefile.lib (15026 bytes)
    /usr/src/linux-headers-4.18.0-15-generic/scripts/Makefile.lib (14968 bytes)
    /usr/src/linux-headers-5.4.0-62-generic/scripts/Makefile.lib (15026 bytes)

Verification

• Start msfconsole
• Get a python meterpreter session on a Linux box
• Start a search from the root directory, ex: search -f *.lib -d /
• Verify that the search actually starts from the root directory instead of the cwd of the session

[gwillcox-r7]

Looks like this is working, will merge this in now.

meterpreter > search
[-] You must specify a valid file glob to search for, e.g. >search -f *.doc
meterpreter > search -f *.lib -d /
Found 11 results...
    /usr/src/linux-headers-5.8.0-43-generic/scripts/Makefile.lib (15593 bytes)
    /usr/src/linux-headers-5.4.0-58-generic/scripts/Makefile.lib (15026 bytes)
    /usr/src/linux-hwe-5.8-headers-5.8.0-43/scripts/Makefile.lib (15593 bytes)
    /usr/src/linux-hwe-5.8-headers-5.8.0-44/scripts/Makefile.lib (15593 bytes)
    /usr/src/linux-headers-5.8.0-44-generic/scripts/Makefile.lib (15593 bytes)
    /usr/src/linux-headers-5.4.0-58/scripts/Makefile.lib (15026 bytes)
    /home/gwillcox/git/metasploit-framework/data/exploits/CVE-2018-8440/ALPC-TaskSched-LPE.lib (1958 bytes)
    /home/gwillcox/git/metasploit-framework/external/source/byakugan/i386/byakugan.lib (4638 bytes)
    /home/gwillcox/git/metasploit-framework/external/source/byakugan/injectsu/lib/detoured.lib (1826 bytes)
    /home/gwillcox/git/metasploit-framework/external/source/byakugan/injectsu/lib/detours.lib (173276 bytes)
    /home/gwillcox/git/metasploit-framework/external/source/byakugan/injectsu/i386/injectsu.lib (1722 bytes)
meterpreter > pwd
/home/gwillcox/git/metasploit-framework
meterpreter > 

[gwillcox-r7]

Release Notes

Fixed the search command within Meterpreter to properly support searches that start at the root directory, aka /. These types of searches were previously not returning any results due to a logic bug within the code, which has now been fixed.